[MLton-commit] r4229

Matthew Fluet MLton@mlton.org
Tue, 15 Nov 2005 15:12:35 -0800


MLton.ProcEnv.setgroups was messed up on many levels.
----------------------------------------------------------------------

U   mlton/trunk/basis-library/libs/basis-extra/top-level/basis.sig
U   mlton/trunk/basis-library/mlton/proc-env.sig
U   mlton/trunk/basis-library/posix/primitive.sml
U   mlton/trunk/doc/changelog

----------------------------------------------------------------------

Modified: mlton/trunk/basis-library/libs/basis-extra/top-level/basis.sig
===================================================================
--- mlton/trunk/basis-library/libs/basis-extra/top-level/basis.sig	2005-11-15 23:10:46 UTC (rev 4228)
+++ mlton/trunk/basis-library/libs/basis-extra/top-level/basis.sig	2005-11-15 23:12:32 UTC (rev 4229)
@@ -319,6 +319,7 @@
 
       sharing type MLton.IntInf.t = IntInf.int
       sharing type MLton.Process.pid = Posix.Process.pid
+      sharing type MLton.ProcEnv.gid = Posix.ProcEnv.gid
       sharing type MLton.Signal.t = Posix.Signal.signal
       sharing type MLton.Word.t = Word.word
       sharing type MLton.Word8.t = Word8.word

Modified: mlton/trunk/basis-library/mlton/proc-env.sig
===================================================================
--- mlton/trunk/basis-library/mlton/proc-env.sig	2005-11-15 23:10:46 UTC (rev 4228)
+++ mlton/trunk/basis-library/mlton/proc-env.sig	2005-11-15 23:12:32 UTC (rev 4229)
@@ -8,6 +8,8 @@
 
 signature MLTON_PROC_ENV =
    sig
+      type gid
+
       val setenv: {name: string, value: string} -> unit
-      val setgroups: Posix.ProcEnv.gid list -> unit
+      val setgroups: gid list -> unit
    end

Modified: mlton/trunk/basis-library/posix/primitive.sml
===================================================================
--- mlton/trunk/basis-library/posix/primitive.sml	2005-11-15 23:10:46 UTC (rev 4228)
+++ mlton/trunk/basis-library/posix/primitive.sml	2005-11-15 23:12:32 UTC (rev 4229)
@@ -269,7 +269,7 @@
             val setenv =
                _import "Posix_ProcEnv_setenv": NullString.t * NullString.t -> int;
             val setgid = _import "Posix_ProcEnv_setgid": gid -> int;
-            val setgroups = _import "Posix_ProcEnv_getgroups": gid array -> int;
+            val setgroups = _import "Posix_ProcEnv_setgroups": gid array -> int;
             val setpgid = _import "Posix_ProcEnv_setpgid": Pid.t * Pid.t -> int;
             val setsid = _import "Posix_ProcEnv_setsid": unit -> Pid.t;
             val setuid = _import "Posix_ProcEnv_setuid": uid -> int;

Modified: mlton/trunk/doc/changelog
===================================================================
--- mlton/trunk/doc/changelog	2005-11-15 23:10:46 UTC (rev 4228)
+++ mlton/trunk/doc/changelog	2005-11-15 23:12:32 UTC (rev 4229)
@@ -1,5 +1,8 @@
 Here are the changes since version 20041109.
 
+* 2005-11-15
+  - Fixed a bug in MLton.ProcEnv.setgroups.
+
 * 2005-11-11
   - Fixed a bug in the interleaving of lexing/parsing and elaborating of
     ML Basis files, which would raise an unhandled Force exception on