[MLton-devel] Request for advice for patch: FreeBSD 5.x Support

Stephen Weeks MLton@mlton.org
Tue, 22 Jul 2003 15:48:25 -0700


> The first patch applies the flag-changes that has occured with the
> change from GCC2.95.x to GCC3.x. Mainly it is just flags that have been
> pushed around. What nags me here is that I cannot change it since it
> would probably make GCC2.95.x unable to compile the runtime environment.
...
> So my question is: What should we do in order to apply the patch below?

I've seen the same warnings on Debian, which has also switched to GCC
3.x.  I think it is best to leave the flags as is, since they work on
all GCC's.  Whenever newer versions of GCC don't accept
-malign-functions and friends, then we will have to solve the problem.
And maybe by then we will be able to switch to -f.

> The second patch is more fair. FreeBSD5.x sys/resources.h include uses
> struct timeval for it's resources. This is defined in sys/time.h but
> does not get included by default. It is up to the programmer to include
> that file, should he include resources.h.

I'm not sure why "#include <sys/resource.h>" is in gc.h, but given
that it is, I think that we should have "#include <sys/time.h>" in
front of it.  That works on all our platforms.

I've checked in the change.



-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
_______________________________________________
MLton-devel mailing list
MLton-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mlton-devel