[MLton] Shared libraries for MLton

[Matthew Fluet]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--1417689696-2050599397-1122581633=:14282
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.LNX.4.58.0507281617211.14282@lion.cs.cornell.edu>


> >>>>>    o NOTE: The first garbage collection provokes a crash, the
> >>>>>            error is probably to be found here.
> 
> >>As best I can make out, the problem is that the Thread_returnToC primitive 
> >>does not leave the ML stack in a good state.  Apparently, we don't do as 
> >>many assertions and don't make as many assumptions about the 
> >>callFromCHandler thread as we do about the currentThread.  And, whatever 
> >>bad state the callFromCHandler thread is in, it is fixed when transfering 
> >>control to an _export-ed ML function before a GC occurs when the 
> >>callFromCHandler thread as been switched to.
> 
> > Interestingly enough, if I add
> > 
> > 	GC_switchToThread (&gcState, gcState.callFromCHandler, 0);	\
> > 
> > to the end of init_function in c-main.h, then I can get Jens' example to 
> > compile and run without any segfault.  As a bonus, this also works for the 
> > bytecode codegen, though the native x86 codegen has a mysterious segfault 
> > when trying to return to init_function.
> 
> Did you do more? If I add the above line, recompile mltin and then run 
> the c-test I get:
> 
>    ...
>    init_function> After main
>    Call from C to SML raised exception.
>    unhandled exception: Fail: Thread.atomicEnd with no atomicBegin

Yes, you need to modify basis-library/mlton/mlton.sml to inc the atomic 
state before returning to C, since the thread switch will dec the atomic 
state.

I've attached my current diff, based on your previous patch and following
my recent commit to regularize the names of _build_const constants.
--1417689696-2050599397-1122581633=:14282
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="shared-library.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.58.0507281613530.14282@lion.cs.cornell.edu>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME="shared-library.patch"

SW5kZXg6IGluY2x1ZGUvYy1tYWluLmgNCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9tbHRvbi9tbHRvbi9pbmNsdWRlL2Mt
bWFpbi5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMw0KZGlmZiAtcjEu
MTMgYy1tYWluLmgNCjU5YzU5LDc4DQo8IH0NCi0tLQ0KPiB9ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBcDQo+IHZvaWQgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIFwNCj4gIF9fYXR0cmlidXRlX18oKGNvbnN0cnVjdG9yKSkJCQkJCQlc
DQo+IGluaXRfZnVuY3Rpb24gKGludCBkdW1teSkgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4geyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgXA0KPiAgICAgICAgIGludCBhcmdjPTE7ICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBcDQo+ICAgICAgICAgdm9pZCAqYXJndlsyXTsgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4gCXN0
cnVjdCBjb250IGNvbnQ7CQkJCQkJXA0KPiAgICAgICAgIGFyZ3ZbMF0gPSAi
YmFyIjsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBcDQo+ICAgICAgICAgYXJndlsxXSA9IE5VTEw7ICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4g
CUluaXRpYWxpemUgKGFsLCBtZywgbWZzLCBtbWMsIHBrLCBwcyk7CQkJCVwN
Cj4gCXJlYWxfSW5pdCgpOwkJCQkgICAgICAJCSAgICAgICAgXA0KPiAJUHJl
cEZhckp1bXAobWMsIG1sKTsJCQkJCSAgICAgICAgXA0KPiAJLyogVHJhbXBv
bGluZSAqLwkJCQkJCVwNCj4gICAgICAgICByZXR1cm5Ub0MgPSBGQUxTRTsg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
XA0KPiAJZG8geyAgCQkJCQkJCSAgICAgICAgXA0KPiAgCQljb250PSgqKHN0
cnVjdCBjb250KCopKHZvaWQpKWNvbnQubmV4dENodW5rKSgpOwkJXA0KPiAJ
fSB3aGlsZSAobm90IHJldHVyblRvQyk7CQkJCQlcDQo+IAlHQ19zd2l0Y2hU
b1RocmVhZCAoJmdjU3RhdGUsIGdjU3RhdGUuY2FsbEZyb21DSGFuZGxlciwg
MCk7CVwNCj4gfSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KNjFhODEN
Cj4gDQpJbmRleDogYmFzaXMtbGlicmFyeS9taXNjL3ByaW1pdGl2ZS5zbWwN
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9t
bHRvbi9tbHRvbi9iYXNpcy1saWJyYXJ5L21pc2MvcHJpbWl0aXZlLnNtbCx2
DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTU3DQpkaWZmIC1yMS4xNTcgcHJp
bWl0aXZlLnNtbA0KMTcyNGExNzI1LDE3MjYNCj4gCSAgICB2YWwgc2hhcmVk
TGlicmFyeSA9DQo+IAkgICAgICAgX2J1aWxkX2NvbnN0ICJNTHRvbl9Ub3BM
ZXZlbF9zaGFyZWRMaWJyYXJ5IjogYm9vbDsNCkluZGV4OiBiYXNpcy1saWJy
YXJ5L21sdG9uL21sdG9uLnNtbA0KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
UkNTIGZpbGU6IC9jdnNyb290L21sdG9uL21sdG9uL2Jhc2lzLWxpYnJhcnkv
bWx0b24vbWx0b24uc21sLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS40MA0K
ZGlmZiAtcjEuNDAgbWx0b24uc21sDQo4M2M4Myw4Nw0KPCAgICAgICAoZm4g
KCkgPT4gTUx0b25Qcm9jZXNzLmV4aXQgTUx0b25Qcm9jZXNzLlN0YXR1cy5z
dWNjZXNzKSkNCi0tLQ0KPiAgICAgICAoZm4gKCkgPT4gaWYgUHJpbWl0aXZl
LlRvcExldmVsLnNoYXJlZExpYnJhcnkNCj4gICAgICAgICAgICAgICAgIHRo
ZW4gKFByaW1pdGl2ZS5UaHJlYWQuYXRvbWljQmVnaW4gKCkNCj4gCQkgICAg
ICA7IFByaW1pdGl2ZS5UaHJlYWQucmV0dXJuVG9DICgpDQo+IAkJICAgICAg
OyBNTHRvblByb2Nlc3MuZXhpdCBNTHRvblByb2Nlc3MuU3RhdHVzLmZhaWx1
cmUpDQo+ICAgICAgICAgICAgICAgICBlbHNlIE1MdG9uUHJvY2Vzcy5leGl0
IE1MdG9uUHJvY2Vzcy5TdGF0dXMuc3VjY2VzcykpDQpJbmRleDogbWx0b24v
Y29udHJvbC9jb250cm9sLWZsYWdzLnNpZw0KPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L21sdG9uL21sdG9uL21sdG9uL2Nv
bnRyb2wvY29udHJvbC1mbGFncy5zaWcsdg0KcmV0cmlldmluZyByZXZpc2lv
biAxLjUNCmRpZmYgLXIxLjUgY29udHJvbC1mbGFncy5zaWcNCjI1MmEyNTMs
MjU1DQo+ICAgICAgICgqIEdlbmVyYXRlIHNoYXJlZCBsaWJyYXJ5IHVzaW5n
IHRoZSBDIGJhY2tlbmQgKikNCj4gICAgICAgdmFsIHNoYXJlZExpYnJhcnk6
IGJvb2wgcmVmDQo+IA0KSW5kZXg6IG1sdG9uL2NvbnRyb2wvY29udHJvbC1m
bGFncy5zbWwNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAv
Y3Zzcm9vdC9tbHRvbi9tbHRvbi9tbHRvbi9jb250cm9sL2NvbnRyb2wtZmxh
Z3Muc21sLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS42DQpkaWZmIC1yMS42
IGNvbnRyb2wtZmxhZ3Muc21sDQo2NzBhNjcxLDY3Mg0KPiB2YWwgc2hhcmVk
TGlicmFyeSA9IHJlZiBmYWxzZTsNCj4gDQpJbmRleDogbWx0b24vbWFpbi9s
b29rdXAtY29uc3RhbnQuZnVuDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS
Q1MgZmlsZTogL2N2c3Jvb3QvbWx0b24vbWx0b24vbWx0b24vbWFpbi9sb29r
dXAtY29uc3RhbnQuZnVuLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xOQ0K
ZGlmZiAtcjEuMTkgbG9va3VwLWNvbnN0YW50LmZ1bg0KMzhjMzgsMzkNCjwg
CQkJCQkgICAgICB8IF8gPT4gdHJ1ZSkpXQ0KLS0tDQo+IAkJCQkJICAgICAg
fCBfID0+IHRydWUpKSwNCj4gICAgICAgICgiTUx0b25fVG9wTGV2ZWxfc2hh
cmVkTGlicmFyeSIsIGZuICgpID0+IGJvb2wgKCFzaGFyZWRMaWJyYXJ5KSld
DQpJbmRleDogbWx0b24vbWFpbi9tYWluLmZ1bg0KPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L21sdG9uL21sdG9uL21sdG9u
L21haW4vbWFpbi5mdW4sdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjk2DQpk
aWZmIC1yMS45NiBtYWluLmZ1bg0KMzk3YTM5OCwzOTkNCj4gICAgICAgIChF
eHBlcnQsICJzaGFyZWQtbGlicmFyeSIsICIge2ZhbHNlfHRydWV9IiwNCj4g
ICAgICAgICAiZ2VuZXJhdGUgc2hhcmVkLWxpYnJhcnkiLCBib29sUmVmIENv
bnRyb2wuc2hhcmVkTGlicmFyeSksDQo=

--1417689696-2050599397-1122581633=:14282--