[MLton] Re: Hppa

Stephen Weeks MLton@mlton.org
Wed, 22 Dec 2004 14:10:03 -0800


> > The only fix I see is to change
> > runtime/basis/Real/gdtoa.c to make Real32_gdtoa use the gdtoa library
> > directly modeled on g_ffmt, just as Real64_gdtoa uses the gdtoa
> > library modeled on g_dfmt.  If we're in agreement, I'll do that after
> > applying your c99 patch.
> 
> Sounds fine to me.

OK, I've done this.

> > With that fix, we still may have regression problems with the last
> > digit.  If so, I think the right thing is to tweak the regression to
> > simply drop the last digit.
> 
> If the goal is to make regressions only produce output on actual failure
> conditions, then I agree. For a normal application, printing them all would
> be the right thing to do.

Agreed.  I've updated real.ok to reflect the new output from
Real32.fmt StringCvt.exact, but haven't changed real.sml.  Let's see
how things look now on Hppa.