[MLton] Implementing warnExnMatch

Tue, 26 Jul 2005 20:34:49 +0300

This message is in MIME format.

---MOQ11223992890e5a33681437bcbe7bdd14e0b1934a4e
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Quoting Matthew Fluet <fluet@cs.cornell.edu>:
> You don't want to use unification, because that will raise an error when 
> the types do not unify or it will force an otherwise polymorphic type to 
> be equal to an exception type. [...]

Yes. Although there is the function TypeEnv.Type.canUnify, which is "not
side-effecting".

> It is correct, but as you say, it would probably best be factored into an 
> auxilary function:

Thanks, I applied your patch (isExn) to my working files.

> > Actually, there seems to be some room for abstraction / refactoring. If
> > you look for `val isBool' in `elaborate-core.fun', you'll find out that it
> > is defined three times identically.
> 
> Fair enough, you might push it back as to PrimTycon and TypeEnv.Type as in 
> the patch above.

I haven't refactored the code in this respect.

>   warnMatch () 
>   andalso (not (Type.isExn argType) 
>            orelse warnExnMatch ())

Ok. I also prefer this behavior.

> > Should all of the contexts be subject to `warnExnMatch' [...]
> 
> I think they should apply to all of them. [...]

Ok. It is now applied in all of the contexts, but there are two
special cases. In the case of

  val p1 = e1 and ... and pN = eN

the warning is disabled only if all bindings are of exceptions. In
the case of

  fun f a1 ... aN = ...

the warning is disabled only if N=1 and a1 is an exception.

I also wrote a simple test case.

---MOQ11223992890e5a33681437bcbe7bdd14e0b1934a4e
Content-Type: text/x-patch; name="warnExnMatch.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="warnExnMatch.patch"

SW5kZXg6IG1sdG9uL2FzdC9wcmltLXR5Y29ucy5mdW4KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2
c3Jvb3QvbWx0b24vbWx0b24vbWx0b24vYXN0L3ByaW0tdHljb25zLmZ1bix2CnJldHJpZXZpbmcg
cmV2aXNpb24gMS4yOQpkaWZmIC11IC1yMS4yOSBwcmltLXR5Y29ucy5mdW4KLS0tIG1sdG9uL2Fz
dC9wcmltLXR5Y29ucy5mdW4JMTkgSnVuIDIwMDUgMjE6MzM6NDEgLTAwMDAJMS4yOQorKysgbWx0
b24vYXN0L3ByaW0tdHljb25zLmZ1bgkyNiBKdWwgMjAwNSAxNzozMDoyMSAtMDAwMApAQCAtMzEs
NiArMzEsOCBAQAogZGF0YXR5cGUgeiA9IGRhdGF0eXBlIEtpbmQudAogZGF0YXR5cGUgeiA9IGRh
dGF0eXBlIEFkbWl0c0VxdWFsaXR5LnQKIAordmFsIGlzRXhuID0gZm4gYyA9PiBlcXVhbHMgKGMs
IGV4bikKKwogbG9jYWwKICAgIGZ1biAnYSBtYWtlIChwcmVmaXg6IHN0cmluZywKIAkJYWxsOiAn
YSBsaXN0LApJbmRleDogbWx0b24vYXN0L3ByaW0tdHljb25zLnNpZwo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm
aWxlOiAvY3Zzcm9vdC9tbHRvbi9tbHRvbi9tbHRvbi9hc3QvcHJpbS10eWNvbnMuc2lnLHYKcmV0
cmlldmluZyByZXZpc2lvbiAxLjE2CmRpZmYgLXUgLXIxLjE2IHByaW0tdHljb25zLnNpZwotLS0g
bWx0b24vYXN0L3ByaW0tdHljb25zLnNpZwkxNCBKYW4gMjAwNSAwMToyMzozNiAtMDAwMAkxLjE2
CisrKyBtbHRvbi9hc3QvcHJpbS10eWNvbnMuc2lnCTI2IEp1bCAyMDA1IDE3OjMwOjIxIC0wMDAw
CkBAIC00Niw2ICs0Niw3IEBACiAgICAgICB2YWwgaW50czogKHR5Y29uICogSW50U2l6ZS50KSB2
ZWN0b3IKICAgICAgIHZhbCBpbnRJbmY6IHR5Y29uCiAgICAgICB2YWwgaXNDaGFyWDogdHljb24g
LT4gYm9vbAorICAgICAgdmFsIGlzRXhuOiB0eWNvbiAtPiBib29sCiAgICAgICB2YWwgaXNJbnRY
OiB0eWNvbiAtPiBib29sCiAgICAgICB2YWwgaXNSZWFsWDogdHljb24gLT4gYm9vbAogICAgICAg
dmFsIGlzV29yZFg6IHR5Y29uIC0+IGJvb2wKSW5kZXg6IG1sdG9uL2NvbnRyb2wvY29udHJvbC1m
bGFncy5zaWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvbWx0b24vbWx0b24vbWx0b24v
Y29udHJvbC9jb250cm9sLWZsYWdzLnNpZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40CmRpZmYg
LXUgLXIxLjQgY29udHJvbC1mbGFncy5zaWcKLS0tIG1sdG9uL2NvbnRyb2wvY29udHJvbC1mbGFn
cy5zaWcJMjMgSnVsIDIwMDUgMTE6NTU6MzkgLTAwMDAJMS40CisrKyBtbHRvbi9jb250cm9sL2Nv
bnRyb2wtZmxhZ3Muc2lnCTI2IEp1bCAyMDA1IDE3OjMwOjIxIC0wMDAwCkBAIC03Miw2ICs3Miw3
IEBACiAJICAgICgqIGluIChlMTsgZTIpLCByZXF1aXJlIGUxOiB1bml0LiAqKQogCSAgICB2YWwg
c2VxdWVuY2VVbml0OiAoYm9vbCxib29sKSB0CiAJICAgIHZhbCB3YXJuTWF0Y2g6IChib29sLGJv
b2wpIHQKKwkgICAgdmFsIHdhcm5FeG5NYXRjaDogKGJvb2wsYm9vbCkgdAogCSAgICB2YWwgd2Fy
blVudXNlZDogKGJvb2wsYm9vbCkgdAogCiAJICAgIHZhbCBjdXJyZW50OiAoJ2FyZ3MsICdzdCkg
dCAtPiAnc3QKSW5kZXg6IG1sdG9uL2NvbnRyb2wvY29udHJvbC1mbGFncy5zbWwKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQpSQ1MgZmlsZTogL2N2c3Jvb3QvbWx0b24vbWx0b24vbWx0b24vY29udHJvbC9jb250cm9sLWZs
YWdzLnNtbCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41CmRpZmYgLXUgLXIxLjUgY29udHJvbC1m
bGFncy5zbWwKLS0tIG1sdG9uL2NvbnRyb2wvY29udHJvbC1mbGFncy5zbWwJMjMgSnVsIDIwMDUg
MTE6NTU6MzkgLTAwMDAJMS41CisrKyBtbHRvbi9jb250cm9sL2NvbnRyb2wtZmxhZ3Muc21sCTI2
IEp1bCAyMDA1IDE3OjMwOjIxIC0wMDAwCkBAIC0zMzQsNiArMzM0LDggQEAKIAkgICAgbWFrZUJv
b2wgKHtuYW1lID0gInNlcXVlbmNlVW5pdCIsIGRlZmF1bHQgPSBmYWxzZSwgZXhwZXJ0ID0gZmFs
c2V9LCBhYykKIAkgdmFsICh3YXJuTWF0Y2gsIGFjKSA9CiAJICAgIG1ha2VCb29sICh7bmFtZSA9
ICJ3YXJuTWF0Y2giLCBkZWZhdWx0ID0gdHJ1ZSwgZXhwZXJ0ID0gZmFsc2V9LCBhYykKKwkgdmFs
ICh3YXJuRXhuTWF0Y2gsIGFjKSA9CisJICAgIG1ha2VCb29sICh7bmFtZSA9ICJ3YXJuRXhuTWF0
Y2giLCBkZWZhdWx0ID0gdHJ1ZSwgZXhwZXJ0ID0gZmFsc2V9LCBhYykKIAkgdmFsICh3YXJuVW51
c2VkLCBhYykgPQogCSAgICBtYWtlQm9vbCAoe25hbWUgPSAid2FyblVudXNlZCIsIGRlZmF1bHQg
PSBmYWxzZSwgZXhwZXJ0ID0gZmFsc2V9LCBhYykKIAkgdmFsIHtwYXJzZUlkLCBwYXJzZUlkQW5k
QXJncywgd2l0aERlZiwgc25hcHNob3R9ID0gYWMKSW5kZXg6IG1sdG9uL2VsYWJvcmF0ZS9lbGFi
b3JhdGUtY29yZS5mdW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvbWx0b24vbWx0b24v
bWx0b24vZWxhYm9yYXRlL2VsYWJvcmF0ZS1jb3JlLmZ1bix2CnJldHJpZXZpbmcgcmV2aXNpb24g
MS4xNTMKZGlmZiAtdSAtcjEuMTUzIGVsYWJvcmF0ZS1jb3JlLmZ1bgotLS0gbWx0b24vZWxhYm9y
YXRlL2VsYWJvcmF0ZS1jb3JlLmZ1bgkyMyBKdWwgMjAwNSAxMTo1NTo0MCAtMDAwMAkxLjE1Mwor
KysgbWx0b24vZWxhYm9yYXRlL2VsYWJvcmF0ZS1jb3JlLmZ1bgkyNiBKdWwgMjAwNSAxNzozMDoy
MiAtMDAwMApAQCAtMTcsNiArMTcsNyBAQAogICAgdmFsIGFsbG93UmViaW5kRXF1YWxzID0gZm4g
KCkgPT4gY3VycmVudCBhbGxvd1JlYmluZEVxdWFscwogICAgdmFsIHNlcXVlbmNlVW5pdCA9IGZu
ICgpID0+IGN1cnJlbnQgc2VxdWVuY2VVbml0CiAgICB2YWwgd2Fybk1hdGNoID0gZm4gKCkgPT4g
Y3VycmVudCB3YXJuTWF0Y2gKKyAgIHZhbCB3YXJuRXhuTWF0Y2ggPSBmbiAoKSA9PiBjdXJyZW50
IHdhcm5FeG5NYXRjaAogZW5kCiAKIGxvY2FsCkBAIC0xOTA5LDcgKzE5MTAsMTIgQEAKIAkJCQkJ
ICAgICBDZXhwLnR1cGxlCiAJCQkJCSAgICAgKFZlY3Rvci5tYXAyCiAJCQkJCSAgICAgICh4cywg
YXJnVHlwZXMsIENleHAudmFyKSksCi0JCQkJCSAgICAgd2Fybk1hdGNoID0gd2Fybk1hdGNoICgp
fQorCQkJCQkgICAgIHdhcm5NYXRjaCA9CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB3YXJuTWF0Y2ggKCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGFuZGFsc28gKG5vdCAoMSA9IFZlY3Rvci5sZW5ndGggYXJnVHlwZXMK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgYW5kYWxzbyBUeXBlLmlzRXhuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoVmVjdG9yLnN1YiAoYXJnVHlwZXMs
IDApKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIG9yZWxzZSB3YXJuRXhuTWF0Y2ggKCkpfQogCQkJCSAgICAgIGluCiAJCQkJCSBDZXhwLmVu
dGVyTGVhdmUKIAkJCQkJIChlLCBwcm9maWxlQm9keSwgc291cmNlSW5mbykKQEAgLTIxMDYsNyAr
MjExMiw5IEBACiAJCQkJCSAgICAgcmVnaW9uID0gcmVnaW9uLAogCQkJCQkgICAgIHJ1bGVzID0g
cnVsZXMsCiAJCQkJCSAgICAgdGVzdCA9IENleHAudmFyIChhcmcsIGFyZ1R5cGUpLAotCQkJCQkg
ICAgIHdhcm5NYXRjaCA9IHdhcm5NYXRjaCAoKX0sCisJCQkJCSAgICAgd2Fybk1hdGNoID0gd2Fy
bk1hdGNoICgpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBhbmRhbHNvIChub3QgKFR5cGUuaXNFeG4gYXJnVHlwZSkKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9y
ZWxzZSB3YXJuRXhuTWF0Y2ggKCkpfSwKIAkJCQkgcHJvZmlsZUJvZHksCiAJCQkJIGZuICgpID0+
IFNvdXJjZUluZm8uZnVuY3Rpb24ge25hbWUgPSBuZXN0LAogCQkJCQkJCSAgICAgICByZWdpb24g
PSByZWdpb259KQpAQCAtMjE5Nyw3ICsyMjA1LDExIEBACiAJCSAgICAgIChDZGVjLlZhbCB7cnZi
cyA9IHJ2YnMsCiAJCQkJIHR5dmFycyA9IGJvdW5kLAogCQkJCSB2YnMgPSB2YnMsCi0JCQkJIHdh
cm5NYXRjaCA9IHdhcm5NYXRjaCAoKX0pCisJCQkJIHdhcm5NYXRjaCA9IHdhcm5NYXRjaCAoKQor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5kYWxzbyAobm90
IChWZWN0b3IuZm9yYWxsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICh2YnMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBUeXBlLmlzRXhuIG8gQ2V4cC50eSBvICNleHAp
KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
b3JlbHNlIHdhcm5FeG5NYXRjaCAoKSl9KQogCQkgICBlbmQKIAkgIGVuZCkgYXJnCiAgICAgICBh
bmQgZWxhYkV4cCAoYXJnOiBBZXhwLnQgKiBOZXN0LnQgKiBzdHJpbmcgb3B0aW9uKTogQ2V4cC50
ID0KQEAgLTIyNzksNyArMjI5MSw5IEBACiAJCQkJICByZWdpb24gPSByZWdpb24sCiAJCQkJICBy
dWxlcyA9IHJ1bGVzLAogCQkJCSAgdGVzdCA9IGUsCi0JCQkJICB3YXJuTWF0Y2ggPSB3YXJuTWF0
Y2ggKCl9CisJCQkJICB3YXJuTWF0Y2ggPSB3YXJuTWF0Y2ggKCkKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhbmRhbHNvIChub3QgKFR5cGUuaXNFeG4gYXJn
VHlwZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBvcmVsc2Ugd2FybkV4bk1hdGNoICgpKX0KIAkJICAgZW5kCiAJICAgICAgfCBBZXhwLkNv
bnN0IGMgPT4KIAkJICAgZWxhYkNvbnN0CkBAIC0yOTExLDcgKzI5MjUsOSBAQAogCQkJICAgcmVn
aW9uID0gcmVnaW9uLAogCQkJICAgcnVsZXMgPSBydWxlcywKIAkJCSAgIHRlc3QgPSBDZXhwLnZh
ciAoYXJnLCBhcmdUeXBlKSwKLQkJCSAgIHdhcm5NYXRjaCA9IHdhcm5NYXRjaCAoKX0KKwkJCSAg
IHdhcm5NYXRjaCA9IHdhcm5NYXRjaCAoKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgYW5kYWxzbyAobm90IChUeXBlLmlzRXhuIGFyZ1R5cGUpCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvcmVsc2Ugd2FybkV4bk1hdGNoICgp
KX0KIAkgaW4KIAkgICB7YXJnID0gYXJnLAogCSAgICBhcmdUeXBlID0gYXJnVHlwZSwKSW5kZXg6
IG1sdG9uL2VsYWJvcmF0ZS90eXBlLWVudi5mdW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jv
b3QvbWx0b24vbWx0b24vbWx0b24vZWxhYm9yYXRlL3R5cGUtZW52LmZ1bix2CnJldHJpZXZpbmcg
cmV2aXNpb24gMS41NgpkaWZmIC11IC1yMS41NiB0eXBlLWVudi5mdW4KLS0tIG1sdG9uL2VsYWJv
cmF0ZS90eXBlLWVudi5mdW4JMTkgSnVuIDIwMDUgMjE6MzM6NTggLTAwMDAJMS41NgorKysgbWx0
b24vZWxhYm9yYXRlL3R5cGUtZW52LmZ1bgkyNiBKdWwgMjAwNSAxNzozMDoyMiAtMDAwMApAQCAt
Nzc0LDYgKzc3NCwxMSBAQAogCSAgfCBPdmVybG9hZCBPdmVybG9hZC5DaGFyID0+IHRydWUKICAJ
ICB8IF8gPT4gZmFsc2UKIAorICAgICAgZnVuIGlzRXhuIHQgPQorICAgICAgICAgY2FzZSB0b1R5
cGUgdCBvZgorICAgICAgICAgICAgQ29uIChjLCBfKSA9PiBUeWNvbi5pc0V4biBjCisgICAgICAg
ICAgfCBfID0+IGZhbHNlCisKICAgICAgIGZ1biBpc0ludCB0ID0KIAkgY2FzZSB0b1R5cGUgdCBv
ZgogCSAgICBDb24gKGMsIF8pID0+IFR5Y29uLmlzSW50WCBjCkluZGV4OiBtbHRvbi9lbGFib3Jh
dGUvdHlwZS1lbnYuc2lnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L21sdG9uL21sdG9u
L21sdG9uL2VsYWJvcmF0ZS90eXBlLWVudi5zaWcsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjkK
ZGlmZiAtdSAtcjEuMjkgdHlwZS1lbnYuc2lnCi0tLSBtbHRvbi9lbGFib3JhdGUvdHlwZS1lbnYu
c2lnCTIwIE1heSAyMDA1IDE2OjM0OjI3IC0wMDAwCTEuMjkKKysrIG1sdG9uL2VsYWJvcmF0ZS90
eXBlLWVudi5zaWcJMjYgSnVsIDIwMDUgMTc6MzA6MjIgLTAwMDAKQEAgLTM4LDYgKzM4LDcgQEAK
IAkJCSAgcmVwbGFjZVN5bm9ueW1zOiBib29sLAogCQkJICB2YXI6IFR5dmFyLnQgLT4gJ2F9IC0+
ICdhCiAJICAgIHZhbCBpc0NoYXJYOiB0IC0+IGJvb2wKKyAgICAgICAgICAgIHZhbCBpc0V4bjog
dCAtPiBib29sCiAJICAgIHZhbCBpc0ludDogdCAtPiBib29sCiAJICAgIHZhbCBpc1VuaXQ6IHQg
LT4gYm9vbAogCSAgICB2YWwgbGF5b3V0OiB0IC0+IExheW91dC50Cg==

---MOQ11223992890e5a33681437bcbe7bdd14e0b1934a4e
Content-Type: application/smil; name="warn-exn-match.sml"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="warn-exn-match.sml"

ZXhjZXB0aW9uIFJlYyBvZiBleG4KCigqIFRoZXNlIGdpdmUgbm8gd2FybmluZyB3aXRoIGFubm90
YXRpb24gYHdhcm5FeG5NYXRjaCBmYWxzZScuICopCmZ1biBjYXVzZSAoUmVjIGV4bikgPSBjYXVz
ZSBleG4KdmFsIHJlYyBjYXVzZSA9IGZuIFJlYyBleG4gPT4gY2F1c2UgZXhuCnZhbCBCaW5kID0g
QmluZCBhbmQgU2l6ZSA9IFNpemUKZnVuIGNhdXNlIGV4biA9IGNhc2UgZXhuIG9mIFJlYyBleG4g
PT4gZXhuCnZhbCBtYXRjaFRlc3QgPSBmbiBTaXplID0+ICgpCgooKiBUaGVzZSBnaXZlIHdhcm5p
bmdzIHdpdGggYW5ub3RhdGlvbiBgd2FybkV4bk1hdGNoIGZhbHNlJy4gKikKdmFsIFNpemUgPSBT
aXplIGFuZCBfID0gNQpmdW4gY2F1c2UgKFJlYyBleG4pIHggPSBjYXVzZSBleG4geAo=

---MOQ11223992890e5a33681437bcbe7bdd14e0b1934a4e--