[MLton] reason for mprotect with PROT_EXEC ?

[Adam Goode]

Matthew Fluet wrote:
> On Sat, 9 Feb 2008, Adam Goode wrote:
>>>> The function is GC_mmapAnon_safe_protect, and it looks like it is only
>>>> called once, through GC_init and initSignalStack. I doubt the signal
>>>> stack needs to be executable, but I am not totally sure. Am I right
>>>> that
>>>> profiling is the only thing that uses the signal stack?
> 
> BTW, profiling is not the only thing that uses the signal stack.  Any
> SML program that uses MLton.Signal to install a non-default signal
> handler will end up using the alternate signal stack.
> 

One question I have is: how should I test my patch to make sure I have
not broken anything?

Wesley: do you have a code snippet that would crash for you before the
PROT_EXEC change in 2004?



Thanks,

Adam

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
Url : http://mlton.org/pipermail/mlton/attachments/20080214/245ad29d/signature.pgp